pnowojski commented on a change in pull request #13180:
URL: https://github.com/apache/flink/pull/13180#discussion_r472142222
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -387,6 +387,7 @@ function check_logs_for_exceptions {
| grep -v "WARN
org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline" \
| grep -v 'INFO.*AWSErrorCode' \
| grep -v "RejectedExecutionException" \
+ | grep -v "CancellationException" \
Review comment:
Why has this had to be added? Is it caused by one of your change?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -887,7 +887,8 @@ public void receiveDeclineMessage(DeclineCheckpoint
message, String taskManagerL
checkpointId,
message.getTaskExecutionId(),
job,
- taskManagerLocationInfo);
+ taskManagerLocationInfo,
+ message.getReason());
Review comment:
Isn't this is missing a pattern/format change? Also how would you like
it to be logged? Just the `message.getReason().toString()`? Do we care about
the stack trace?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
