wuchong edited a comment on pull request #13177: URL: https://github.com/apache/flink/pull/13177#issuecomment-675840028
Thanks for the contribution @oikomi , after going through it roughly, I have some concern that we are making the `TableSchema` fatter and fatter. The community had some discussion to introduce a `CatalogTableSchema` to preserve the metadata information of catalog table and keep TableSchema clean to describe a schema (see FLINK-17793). Obviously, the column comment should belong to `CatalogTableSchema`. So I'm hesitated whether we should wait for FLINK-17793 or update `TableSchema` further. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
