wuchong commented on a change in pull request #12908:
URL: https://github.com/apache/flink/pull/12908#discussion_r472680410
##########
File path:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/table/Kafka010DynamicSource.java
##########
@@ -54,7 +59,8 @@
*/
public Kafka010DynamicSource(
DataType outputDataType,
- String topic,
+ @Nullable List<String> topics,
+ @Nullable Pattern topicPattern,
Review comment:
Currently, it is very verbose to pass through these to parameters
together here and there. An improvement is that we can use
`KafkaTopicsDescriptor`, but this can be another issue in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
