[ 
https://issues.apache.org/jira/browse/FLINK-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181153#comment-17181153
 ] 

ZhuShang commented on FLINK-18850:
----------------------------------

hi [~libenchao], can i take this,if no one else working on this issus.

my solution is : when the element is late to be droped,inc the  
numLateRecordsDropped accumulator.

like this
{code:java}
org.apache.flink.table.runtime.operators.window.WindowOperator

if (isElementDropped) {
   numLateRecordsDropped.inc();// ← add here
   // markEvent will increase numLateRecordsDropped
   lateRecordsDroppedRate.markEvent();
}
{code}
what do you think?

> Add late records dropped metric for row time over windows
> ---------------------------------------------------------
>
>                 Key: FLINK-18850
>                 URL: https://issues.apache.org/jira/browse/FLINK-18850
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Runtime
>            Reporter: Benchao Li
>            Priority: Major
>              Labels: Starter
>
> Currently all the row time over windows in blink planner runtime discards 
> late records silently, it would be good to have a metric about the late 
> records dropping.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to