rmetzger commented on a change in pull request #13217:
URL: https://github.com/apache/flink/pull/13217#discussion_r475533221
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -350,71 +341,42 @@ private boolean isPartialResourceConfigured(JobGraph
jobGraph) {
}, getRpcService().getExecutor());
}
- private CompletableFuture<Void> persistAndRunJob(JobGraph jobGraph)
throws Exception {
+ private Void persistAndRunJob(JobGraph jobGraph) throws Exception {
Review comment:
I have this ugly `Void` and `return null` here so that I can call the
method as a method reference.
My next push will contain an attempt to make this cleaner (by introducing a
`VoidFunctionWithException` interface)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
