wangyang0918 commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r477104459
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/AbstractResourceManagerDriver.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager.active; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.clusterframework.types.ResourceIDRetrievable; +import org.apache.flink.runtime.concurrent.ScheduledExecutor; +import org.apache.flink.util.Preconditions; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Abstract common base class for implementations of {@link ResourceManagerDriver}. + */ +public abstract class AbstractResourceManagerDriver<WorkerType extends ResourceIDRetrievable> + implements ResourceManagerDriver<WorkerType> { + + protected final Logger log = LoggerFactory.getLogger(getClass()); + + protected final Configuration flinkConfig; + protected final Configuration flinkClientConfig; Review comment: Hi @tillrohrmann thanks for pointing out this concern. > Why we are trying to only pass the diff config options, rather that the full configuration? That will make the start commands very long. Also it is hard to distinguish the config options only for TaskManager. So currently, we compare the effective configuration in ResourceManager and client shipped configuration. And then pass the differences. > Is `flinkClientConfig` the original configuration? I think yes. For Yarn and K8s entrypoints(e.g. `YarnJobClusterEntrypoint`, `KubernetesApplicationClusterEntrypoint`, etc.), we do not accept the configured configuration directory(via `--configDir`). Instead we load them from a specific directory(`$PWD` for Yarn and `ENV_FLINK_CONF_DIR` for K8s), both of them are guaranteed correctly setting in the Flink client. However, if we could find out which config options should be passed the TaskManagers, i agree that `flinkClientConfig` could be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
