zhijiangW commented on a change in pull request #13209:
URL: https://github.com/apache/flink/pull/13209#discussion_r479080606
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -285,11 +285,7 @@ public StreamGraph generate() {
alreadyTransformed.put(transform, transformedIds);
}
- if (transform.getBufferTimeout() >= 0) {
- streamGraph.setBufferTimeout(transform.getId(),
transform.getBufferTimeout());
- } else {
- streamGraph.setBufferTimeout(transform.getId(),
defaultBufferTimeout);
Review comment:
We should only set the default timeout for streaming job by design. But
in this procedure we can not determine the `ResultPartitionType` for properly
setting the default value, so I removed that path here.
But the default timeout still validates in the last procedure while
generating `StreamConfig` by `#setDefaultTimeout()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
