[ 
https://issues.apache.org/jira/browse/FLINK-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthias updated FLINK-14422:
-----------------------------
    Description: This issue refers to Step 2 in the implementation proposal of 
[FLIP-102|https://cwiki.apache.org/confluence/display/FLINK/FLIP-102%3A+Add+More+Metrics+to+TaskManager]
  (was: * add getTotalMemorySize and in getAvaliableMemorySize 
NetworkBufferPool 

{code:java}
public long getTotalMemorySize() {
    return 1L * getTotalNumberOfMemorySegments() * memorySegmentSize;
}

public long getAvaliableMemorySize() {
    return 1L * getNumberOfAvailableMemorySegments() * memorySegmentSize;
}
{code}
 
 * update NettyShuffleMetricFactory#registerShuffleMetrics

{code:java}
private static final String METRIC_TOTAL_MEMORY_SEGMENT_TOTALCAPACITY = 
"TotalMemoryCapacity";
private static final String METRIC_TOTAL_MEMORY_SEGMENT_AVALIABLEMEMORY = 
"AvaliableMemory";
private static void registerShuffleMetrics(
    String groupName,
    MetricGroup metricGroup,
    NetworkBufferPool networkBufferPool) {
    MetricGroup networkGroup = metricGroup.addGroup(groupName);
    networkGroup.<Integer, Gauge<Integer>>gauge(METRIC_TOTAL_MEMORY_SEGMENT,
                                                
networkBufferPool::getTotalNumberOfMemorySegments);
    networkGroup.<Integer, Gauge<Integer>>gauge(METRIC_AVAILABLE_MEMORY_SEGMENT,
                                                
networkBufferPool::getNumberOfAvailableMemorySegments);
    networkGroup.<Long, 
Gauge<Long>>gauge(METRIC_TOTAL_MEMORY_SEGMENT_TOTALCAPACITY,
                                          
networkBufferPool::getTotalMemorySize);
    networkGroup.<Long, 
Gauge<Long>>gauge(METRIC_TOTAL_MEMORY_SEGMENT_AVALIABLEMEMORY,
                                          
networkBufferPool::getAvaliableMemorySize);
}
{code})

> Add metric for shuffle memory
> -----------------------------
>
>                 Key: FLINK-14422
>                 URL: https://issues.apache.org/jira/browse/FLINK-14422
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Task
>            Reporter: lining
>            Priority: Major
>
> This issue refers to Step 2 in the implementation proposal of 
> [FLIP-102|https://cwiki.apache.org/confluence/display/FLINK/FLIP-102%3A+Add+More+Metrics+to+TaskManager]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to