[
https://issues.apache.org/jira/browse/FLINK-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187510#comment-17187510
]
Jark Wu commented on FLINK-19064:
---------------------------------
>From the definition of {{configure()}}, it dosn't open any resources, so
>calling {{close()}} doesn't make sense to me.
I think the current method interfaces of {{InputFormat}} is chaotic and I'm not
familiar with {{InputFormat}} enough to fix it. Currently, the
{{openInputFormat}} doesn't happen before {{createInputSplits}}. One approach
will be moving the calling of {{format.openInputFormat()}} from
{{InputFormatSourceFunction#run(ctx)}} to
{{InputFormatSourceFunction#open(params)}}. However, as I said before, I'm not
clear about what's the side effect. We may need to pull in someone familiar
with {{InputFormat}}.
After all, I don't think this is a critical bug, as the problem only happens in
the legacy {{DataSet}} API which is not maintained for some time and will be
removed in the future. Besides, maybe it's time to migrate the HBase source to
the new FLIP-27 source to have the clearly defined interfaces.
> HBaseRowDataInputFormat is leaking resources
> --------------------------------------------
>
> Key: FLINK-19064
> URL: https://issues.apache.org/jira/browse/FLINK-19064
> Project: Flink
> Issue Type: Bug
> Components: Connectors / HBase
> Affects Versions: 1.12.0
> Reporter: Robert Metzger
> Assignee: Nicholas Jiang
> Priority: Critical
> Labels: pull-request-available
>
> {{HBaseRowDataInputFormat.configure()}} is calling {{connectToTable()}},
> which creates a connection to HBase that is not closed again.
> A user reported this problem on the user@ list:
> https://lists.apache.org/thread.html/ra04f6996eb50ee83aabd2ad0d50bec9afb6a924bfbb48ada3269c6d8%40%3Cuser.flink.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
