[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145938#comment-15145938 ]
ASF GitHub Bot commented on FLINK-3226: --------------------------------------- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/1632#discussion_r52826898 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -148,16 +148,24 @@ class CodeGenerator( if (clazz == classOf[FlatMapFunction[_,_]]) { val inputTypeTerm = boxedTypeTermForTypeInfo(input1) (s"void flatMap(Object _in1, org.apache.flink.util.Collector $collectorTerm)", - s"$inputTypeTerm $input1Term = ($inputTypeTerm) _in1;") + List(s"$inputTypeTerm $input1Term = ($inputTypeTerm) _in1;")) } // MapFunction else if (clazz == classOf[MapFunction[_,_]]) { val inputTypeTerm = boxedTypeTermForTypeInfo(input1) ("Object map(Object _in1)", - s"$inputTypeTerm $input1Term = ($inputTypeTerm) _in1;") + List(s"$inputTypeTerm $input1Term = ($inputTypeTerm) _in1;")) } + // FlatJoinFunction + else if (clazz == classOf[FlatJoinFunction[_,_,_]]) { + val inputTypeTerm1 = boxedTypeTermForTypeInfo(input1) + val inputTypeTerm2 = boxedTypeTermForTypeInfo(input2.get) //TODO check this --- End diff -- Why don't you call `getOrElse` here and throw an CodeGenException if input2 is not present? Then we can get rid of the TODO. > Translate optimized logical Table API plans into physical plans representing > DataSet programs > --------------------------------------------------------------------------------------------- > > Key: FLINK-3226 > URL: https://issues.apache.org/jira/browse/FLINK-3226 > Project: Flink > Issue Type: Sub-task > Components: Table API > Reporter: Fabian Hueske > Assignee: Chengxiang Li > > This issue is about translating an (optimized) logical Table API (see > FLINK-3225) query plan into a physical plan. The physical plan is a 1-to-1 > representation of the DataSet program that will be executed. This means: > - Each Flink RelNode refers to exactly one Flink DataSet or DataStream > operator. > - All (join and grouping) keys of Flink operators are correctly specified. > - The expressions which are to be executed in user-code are identified. > - All fields are referenced with their physical execution-time index. > - Flink type information is available. > - Optional: Add physical execution hints for joins > The translation should be the final part of Calcite's optimization process. > For this task we need to: > - implement a set of Flink DataSet RelNodes. Each RelNode corresponds to one > Flink DataSet operator (Map, Reduce, Join, ...). The RelNodes must hold all > relevant operator information (keys, user-code expression, strategy hints, > parallelism). > - implement rules to translate optimized Calcite RelNodes into Flink > RelNodes. We start with a straight-forward mapping and later add rules that > merge several relational operators into a single Flink operator, e.g., merge > a join followed by a filter. Timo implemented some rules for the first SQL > implementation which can be used as a starting point. > - Integrate the translation rules into the Calcite optimization process -- This message was sent by Atlassian JIRA (v6.3.4#6332)