zhijiangW commented on a change in pull request #13286: URL: https://github.com/apache/flink/pull/13286#discussion_r480904057
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java ########## @@ -366,11 +366,10 @@ private void registerAsyncCheckpointRunnable(long checkpointId, AsyncCheckpointR synchronized (lock) { if (closed) { LOG.debug("Cannot register Closeable, this subtaskCheckpointCoordinator is already closed. Closing argument."); - final boolean running = asyncCheckpointRunnable.isRunning(); closeQuietly(asyncCheckpointRunnable); checkState( - !running, - "SubtaskCheckpointCoordinatorImpl was closed without closing asyncCheckpointRunnable %s", + !checkpoints.containsKey(checkpointId), + "SubtaskCheckpointCoordinator was closed without releasing asyncCheckpointRunnable, %s", Review comment: nit: I guess it seem not very readable for message like `.....releasing asyncCheckpointRunnable, 12`. Maybe change to `......releasing asyncCheckpointRunnable for checkpoint 12`? (Take checkpointId = 12 as example). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org