danny0405 opened a new pull request #13293:
URL: https://github.com/apache/flink/pull/13293


   …d by the system with 'EXPR$' prefix
   
   ## What is the purpose of the change
   
   For query
   
   ```sql
   create view tmp_view as
   select * from (
     select f0,
     row_number() over (partition by f0 order by f0 desc) as rowNum
     from source) -- the query would be aliased as "EXPR$1"
     where rowNum = 1
   ```
   When validation, the inner query would have alias assigned by the system 
with prefix "EXPR$1", when in the `Expander`, we replace the id in the inner 
query all with this prefix which is wrong because we do not add the alias to 
the inner query anymore.
   
   To solve the problem, skip the expanding of id with "EXPR$" just like how 
SqlUtil#deriveAliasFromOrdinal added it.
   
   This was introduced by FLINK-18750.
   
   ## Brief change log
   
   - Add fix in `Expander` and add tests
   
   
   ## Verifying this change
   
   Added UT.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not documented
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to