tzulitai commented on a change in pull request #138:
URL: https://github.com/apache/flink-statefun/pull/138#discussion_r480937709
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/httpfn/HttpFunctionSpec.java
##########
@@ -111,14 +138,36 @@ public Builder withMaxRequestDuration(Duration duration) {
return this;
}
+ public Builder withConnectTimeoutDuration(Duration duration) {
+ this.connectTimeout = Objects.requireNonNull(duration);
+ return this;
+ }
+
+ public Builder withReadTimeoutDuration(Duration duration) {
+ this.readTimeout = Objects.requireNonNull(duration);
+ return this;
+ }
+
+ public Builder withWriteTimeoutDuration(Duration duration) {
+ this.writeTimeout = Objects.requireNonNull(duration);
+ return this;
+ }
+
public Builder withMaxNumBatchRequests(int maxNumBatchRequests) {
this.maxNumBatchRequests = maxNumBatchRequests;
return this;
}
public HttpFunctionSpec build() {
return new HttpFunctionSpec(
- functionType, endpoint, states, maxRequestDuration,
maxNumBatchRequests);
+ functionType,
Review comment:
0 duration would mean that the user wants no timeout to be applied.
Should that really be an invalid configuration?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
