tillrohrmann commented on a change in pull request #13181:
URL: https://github.com/apache/flink/pull/13181#discussion_r481087221
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocator.java
##########
@@ -108,27 +122,30 @@
SharedSlotProfileRetriever sharedSlotProfileRetriever =
sharedSlotProfileRetrieverFactory
.createFromBulk(new HashSet<>(executionVertexIds));
Review comment:
Why is it enough to only put `executionVertexIds` in the set of
`MergingSharedSlotProfileRetriever.allBulkPriorAllocationIds`? What if the
failover includes multiple pipelined regions? Won't this mean that it can
happen that the first pipelined regions takes slots from a preceding one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
