[ 
https://issues.apache.org/jira/browse/FLINK-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188404#comment-17188404
 ] 

Timo Walther commented on FLINK-18938:
--------------------------------------

Sorry, I somehow missed the original mentioning.

In general, having a more helpful message is nice. I just don't like hacking a 
better message into methods that were meant to work generic for all kinds of 
factories. Would it already be helpful enough to list all factories that a 
class implements like:

{code}
datagen (DynamicTableSourceFactory, DynamicTableSinkFactory)
elasticsearch-7 (DynamicTableSinkFactory)
test-connector (DynamicTableSourceFactory)
{code}

This would help in all cases where factories are used, not only sources and 
sink but also formats.

> Throw better exception message for quering sink-only connector
> --------------------------------------------------------------
>
>                 Key: FLINK-18938
>                 URL: https://issues.apache.org/jira/browse/FLINK-18938
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Jark Wu
>            Assignee: liufangliang
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, if we are quering a sink-only connector, for example: {{SELECT * 
> FROM elasticsearch_sink}}, a following exception will be thrown:
> {code}
> Caused by: org.apache.flink.table.api.ValidationException: Could not find any 
> factory for identifier 'elasticsearch-7' that implements 
> 'org.apache.flink.table.factories.DynamicTableSourceFactory' in the classpath.
> Available factory identifiers are:
> datagen
> {code}
> The above exception is very misleading, it sounds like that the elasticsearch 
> jar is not loaded, however the elasticsearch jar is in the lib directory of 
> Flink cluster. 
> We can improve the exception that explicitly telling users the found 
> connector only support as sink, can't be used as a source. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to