leonardBang edited a comment on pull request #13245: URL: https://github.com/apache/flink/pull/13245#issuecomment-685239670
> LGTM. It could be worth to mention in the documentation that when **scan.query** is present then **table-name** is ignored Thanks @fpompermaier for the review very much. I consider that a JDBC table can be source table and dimension table(lookup) at the same time, and the **table-name** is necessary when it used as dimension table not matter the **scan.query** is present or not. So how about add an explanation for **scan.query** that if the **scan.query** option is present then **table-name** option is ignored when used as source table ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
