senegalo commented on pull request #12056: URL: https://github.com/apache/flink/pull/12056#issuecomment-685341691
@austince @dawidwys Hey guys, Finally got around doing the changes you suggested. Now we do have a reset message "that was obviously needed for some reason i thought we call the run function with every message !!! which would've create a new instance of the collector that's why i didn't understand why we would need the reset function... sometimes i just amaze myself !" As for the checks, currently the user has to call the `setMessageIdentifiers` so set the correlationId and deliveryTag which if the checks pass would set the `messageValidated` flag to true when that happens the `collect` message accepts and appends the message to the context if not it ignores it if it's `null` it throws an error telling the user that it must be called at least once. Now for the default behavior @dawidwys mentioned, the user has to call the `setMessageIdentifiers` if they are using the custom deserialiser which you would only use to send your custom `correlationId` with. In the default deserializer the method is called automatically so no need for the user to do anything. I really hope that did the trick and i am more than happy to do more if needed :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
