echauchot commented on a change in pull request #13040:
URL: https://github.com/apache/flink/pull/13040#discussion_r482782613
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorMasterHooksTest.java
##########
@@ -459,7 +460,8 @@ private CheckpointCoordinator
instantiateCheckpointCoordinator(
new StandaloneCheckpointIDCounter(),
new StandaloneCompletedCheckpointStore(10),
new MemoryStateBackend(),
- Executors.directExecutor(),
+ executor,
+ new CheckpointsCleaner(executor),
Review comment:
after refactoring (see below) now that CheckpointsCleaner does nothing
(just updates the counter through a callback and expose its value with a
getter) I don't think a mock impl still makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
