echauchot commented on pull request #13040: URL: https://github.com/apache/flink/pull/13040#issuecomment-686379375
@rkhachatryan I just pushed refactoring code to comply with your suggested diagram. To ease the review I left it as a new commit so that you could see the change. But basically what I did is: move checkpoint cleaning logic from _CheckpointCleaner_ to _Checkpoint_ classes to avoid dependencies to _checkpointCleaner_ and make checkpointCleaner only track number of checkpoints to clean. In checkpoint classes interact with checkpoint coordinator and with checkpointCleaner via callbacks. There is no more dependency cycle. I also rebased on master. Please take a look and validate the refactoring before I write the test. Also please read my comment in the discussion about the refactoring. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
