liming30 commented on pull request #13109: URL: https://github.com/apache/flink/pull/13109#issuecomment-687535459
Hi, @pnowojski I have rebase the master and reorganized the commit. > Could you restructure first three commits in the following way ([following our coding style](https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#separate-refactoring-cleanup-and-independent-changes)): > > 1. my `[hotfix][task] Move output and collector helper classes out of OperatorChain` commit > The first commit has been merged into the master, so it is removed from this pr. > 2. your introduction of `SelectedOutputsCollector` - a hotfix/optimisation of the pre-existing code > 3. your functional changes to the metrics counting (current 1st and part of the current 3rd commit) > 4. your `[hotfix] wrapping single RecordWriterOutput with RecordWriterCountingOutput` > Only two commits are retained. The first commit is the introduction of `SelectedOutputsCollector`, and the second commit is a modification of the metrics counting function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
