SteNicholas opened a new pull request #13332:
URL: https://github.com/apache/flink/pull/13332


   ## What is the purpose of the change
   
   *Currently, `sql-client-defaults.yaml` sets some runtime execution 
configuration by defualt, e.g. parallelism, restart strategy. which is 
confusing for users so that users are confused why paralleslim is changed in 
`flink-conf.yaml` but it doesn't work. `sql-client-defaults.yaml` should remove 
the runtime execution configurations, to make the configurations in 
flink-conf.yaml work by default.*
   
   ## Brief change log
   
     - *Remove the runtime execution configurations defined in 
`sql-client-defaults.yaml`, which includes `time-characteristic`, 
`periodic-watermarks-interval`, `parallelism`, `max-parallelism`, 
`restart-strategy`.*
     - *`ExecutionEntry` removes the runtime execution configurations, 
including `time-characteristic`, `periodic-watermarks-interval`, `parallelism`, 
`max-parallelism`, `restart-strategy` etc.*
     - *`createTableConfig` of `ExecutionContext` removes the default execution 
configurations for `time-characteristic`, `periodic-watermarks-interval`, 
`parallelism`, `max-parallelism`, `restart-strategy`.*
   
   ## Verifying this change
   
     - *Modify `testGetSessionProperties()` of `LocalExecutorITCase` to remove 
the default execution configurations to verify the test case for removing the 
runtime execution configuration in `sql-client-defaults.yaml`.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to