zhijiangW opened a new pull request #13337:
URL: https://github.com/apache/flink/pull/13337
## What is the purpose of the change
Currently, MailboxExecutor.isIdle checks whether the mailbox loop is running
or not.
If not, ContinuousFileReaderOperator continues file processing loop without
going through the mailbox.
However, the mailbox can still contain (and receive new) mails (e.g. from
timers) that should be processed.
In particular, this check currently prevents periodic watermarks from being
emitted.
This PR simply removes this check.
## Verifying this change
- Added FileReadingWatermarkITCase
- Existing tests cover the rest of ContinuousFileReaderOperator (e.g.
ContinuousFileProcessingTest)
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
