XComp commented on a change in pull request #374:
URL: https://github.com/apache/flink-web/pull/374#discussion_r484289772
##########
File path: docker-run.sh
##########
@@ -16,10 +16,4 @@
# limitations under the License.
Review comment:
I just found it better fitting since we only do parameter passing in the
end. I found that the intend of make does not include parameter passing. Is
this a correct conclusion? I didn't want to include a third target to support
another parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]