[ 
https://issues.apache.org/jira/browse/FLINK-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191931#comment-17191931
 ] 

Zhu Zhu commented on FLINK-14942:
---------------------------------

[~qinjunjerry] from what I know, shallow copy is not new in 1.11. It has been 
there for quite a long time (at least since 1.9, see 
https://ci.apache.org/projects/flink/flink-docs-release-1.9/dev/libs/state_processor_api.html#modifying-savepoints).
So I agree with [~rmetzger] that it would be better to treat it as a new 
feature and add it in 1.12. 
Or at least it does not need to be a blocker for 1.11.2, which is a bugfix 
release.
I will remove 1.11.x from the fix versions for now. We can add it back if there 
is consensus to port it back to 1.11 in further discussion.

> State Processing API: add an option to make deep copy
> -----------------------------------------------------
>
>                 Key: FLINK-14942
>                 URL: https://issues.apache.org/jira/browse/FLINK-14942
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / State Processor
>    Affects Versions: 1.11.0
>            Reporter: Jun Qin
>            Assignee: Jun Qin
>            Priority: Blocker
>              Labels: pull-request-available, usability
>             Fix For: 1.12.0, 1.11.2
>
>
> Current when a new savepoint is created based on a source savepoint, then 
> there are references in the new savepoint to the source savepoint. Here is 
> the [State Processing API 
> doc|https://ci.apache.org/projects/flink/flink-docs-release-1.9/dev/libs/state_processor_api.html]
>  says: 
> bq. Note: When basing a new savepoint on existing state, the state processor 
> api makes a shallow copy of the pointers to the existing operators. This 
> means that both savepoints share state and one cannot be deleted without 
> corrupting the other!
> This JIRA is to request an option to have a deep copy (instead of shallow 
> copy) such that the new savepoint is self-contained. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to