SteNicholas opened a new pull request #13352:
URL: https://github.com/apache/flink/pull/13352
## What is the purpose of the change
*Currently exception of parser is thrown when adding comment on computed
column with DDL. Parser should support comment on computed column for DDL of
`CREATE TABLE` as follows:*
```
<computed_column_definition>: column_name AS computed_column_expression
[COMMENT column_comment]
```
## Brief change log
- *Add `SqlTableComputedColumn` to support commented computed column in
`Parser.tdd`.*
- *`ComputedColumn ` of `parserImpls.ftl` which creates computed column
returns the `SqlTableComputedColumn`.*
- *`SqlCreateTable` modifies validation and unparse about the computed
column by `SqlTableComputedColumn`.*
- *`MergeTableLikeUtil` modifies the check for the computed column whether
derivedColumn is instance of `SqlTableComputedColumn`.*
## Verifying this change
- *`FlinkSqlParserImplTest` adds
`testCreateTableWithCommentOnComputedColumn` to verify the test case that
creates table with comment on the computed column.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
