xintongsong commented on a change in pull request #13311:
URL: https://github.com/apache/flink/pull/13311#discussion_r484802971
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -135,7 +135,7 @@ public YarnResourceManager(
JobLeaderIdService jobLeaderIdService,
ClusterInformation clusterInformation,
FatalErrorHandler fatalErrorHandler,
- @Nullable String webInterfaceUrl,
+ YarnResourceManagerConfiguration
yarnResourceManagerConfiguration,
Review comment:
It's probably not a big problem, but I would try to avoid directly
accessing system env from a component/plugin like `YarnResourceManager` or
`YarnResourceManagerDriver` if possible. Injecting all the dependencies through
parameters should be more testing friendly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
