aljoscha opened a new pull request #13354:
URL: https://github.com/apache/flink/pull/13354


   In FLINK-14850 we changed the `execute()` method to be basically
   
   ```
   final JobClient jobClient = executeAsync(...);
   return jobClient.getJobExecutionResult(userClassloader).get();
   ```
   
   Unfortunately, this means that `execute()` now throws an 
`ExecutionException` instead of a `ProgramInvocationException` or 
`JobExecutionException` as before. The `ExecutionException` is wrapping the 
other exceptions that we were throwing before.
   
   We didn't notice this in tests because most tests use 
`Test(Stream)Environment` which overrides the `execute()` method and so doesn't 
go through the PipelineExecutor logic or the normal code path of delegating to 
`executeAsync()`.
   
   This change brings us back to the previous behaviour.
   
   ## Brief changelog
   
    - unwrap exception in environments
    - fix tests that were testing the wrong behaviour
   
   ## Verifying this change
   
    - added a new integration test
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **yes**
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to