dawidwys opened a new pull request #13357:
URL: https://github.com/apache/flink/pull/13357
## What is the purpose of the change
This is a preparation for introducing a sorted inputs in BATCH execution
mode. It refactors the UnilateralSortMerger into more composable pieces.
Additionally it adds the option to use a push-based approach instead of
spawning a Reader thread that consumes from an input iterator.
The PR still has a couple of shortcomings:
* the combine function is not being opened (however it did not work well
even before that, the function was being closed before the merge stage)
* it misses tests for the push-based approach (however the reading thread
simply encapsulates the push-based producer)
* it misses a test for testing closing all threads on an exception (the
exception handler was reworked)
## Verifying this change
This change is already covered by existing tests.
Some tests are still to be added.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
**JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
