wangxiyuan commented on pull request #23: URL: https://github.com/apache/flink-docker/pull/23#issuecomment-689237514
> I'm not sure if this PR works as-is. The updated generator doesn't seem to set the architecture flag correctly: https://github.com/apache/flink-docker/pull/23/files#diff-0c5f825c10334c2eff0a90687f513c69R93 > > also, the architecture seems to depend on the architecture of the machine executing the `generate.sh` script. But this script only generates the Dockerfile and metadata file, not the actual docker image. Acutally many docker images support multi arch currently. For example `openjdk:11-jre` https://github.com/wangxiyuan/flink-docker/blob/dev-master/generator.sh#L18-L22 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
