becketqin opened a new pull request #13366:
URL: https://github.com/apache/flink/pull/13366
## What is the purpose of the change
Currently the `FetchTask`s can only be waken up via `Thread.interrupt()`
when the thread is blocking on putting an element into the
`FutureCompletingBlockingQueue`. To ensure the thread is waken up,
`FetchTask#wakeUp()` pessimistically interrupts the split fetcher thread. This
means that the split fetcher thread might also be interrupted while it is in
`SplitReader#fetch()`. This interruption is problematic because the
`SplitReader` does not necessarily handle interruptions.
This patch solves the problem by adding some logic to the
`FutureCompletingBlockingQueue` so that a thread blocking on putting an element
into the queue can be waken up elegantly.
## Brief change log
a1ca80ac6de0f : Add logic to the `FutureCompletingBlockingQueue` to allow a
putting thread to be waken up elegantly.
38b675997be8 : Change the default capacity of
`FutureCompletingBlockingQueue` to 1.
## Verifying this change
This change added tests:
*
org.apache.flink.connector.base.source.reader.synchronization.FutureCompletingBlockingQueueTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (in the worst
case yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
