sjwiesman commented on a change in pull request #13010:
URL: https://github.com/apache/flink/pull/13010#discussion_r485779807
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/DataGeneratorSource.java
##########
@@ -45,18 +62,34 @@
* @param generator data generator.
*/
public DataGeneratorSource(DataGenerator<T> generator) {
- this(generator, Long.MAX_VALUE);
+ this(generator, "generator", Long.MAX_VALUE, null);
}
/**
* Creates a source that emits records by {@link DataGenerator}.
*
* @param generator data generator.
* @param rowsPerSecond Control the emit rate.
+ * @param numberOfRows Total number of rows to output.
*/
- public DataGeneratorSource(DataGenerator<T> generator, long
rowsPerSecond) {
+ public DataGeneratorSource(DataGenerator<T> generator, String name,
long rowsPerSecond, Long numberOfRows) {
this.generator = generator;
+ this.name = name;
Review comment:
that's a remnant from an old commit, will remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
