[
https://issues.apache.org/jira/browse/FLINK-19175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193344#comment-17193344
]
Danny Chen commented on FLINK-19175:
------------------------------------
Nice catch, [~dwysakowicz], can i take this issue ?
> Tests in JoinITCase do not test BroadcastHashJoin
> -------------------------------------------------
>
> Key: FLINK-19175
> URL: https://issues.apache.org/jira/browse/FLINK-19175
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner, Tests
> Reporter: Dawid Wysakowicz
> Priority: Major
>
> The tests in JoinITCase claim to test the {{BroadcastHashJoin}}, but they
> actually do not. None of the tables used in the tests have proper statistics
> therefore, none of the tables meet the threshold for the broadcast join. At
> the same time the {{ShuffleHashJoin}} is not disabled, therefore they
> silently fallback to {{ShuffleHashJoin}}.
> In summary none (or at least not all of the tests) are executed for
> BroadcastHashJoin, but are executed twice for ShuffleHashJoin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
