wuchong commented on a change in pull request #13352:
URL: https://github.com/apache/flink/pull/13352#discussion_r486161971
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlTableColumn.java
##########
@@ -109,6 +137,14 @@ public void setType(SqlDataTypeSpec type) {
this.type = type;
}
+ public SqlNode getExpr() {
+ return expr;
+ }
+
+ public void setExpr(SqlNode expr) {
Review comment:
This is never used?
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlTableColumn.java
##########
@@ -109,6 +137,14 @@ public void setType(SqlDataTypeSpec type) {
this.type = type;
}
+ public SqlNode getExpr() {
Review comment:
Better to return `Optional<SqlNode>` to keep consistent with other
nullable methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
