rmetzger commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r486233737
##########
File path: docs/_includes/generated/jmx_server_configuration.html
##########
@@ -0,0 +1,18 @@
+<table class="table table-bordered">
Review comment:
Why is this file generated now? (I don't see a code change that triggers
this)
##########
File path: docs/_includes/generated/execution_config_configuration.html
##########
@@ -106,6 +100,12 @@
<td>Boolean</td>
<td>Whether to compress spilled data. Currently we only support
compress spilled data for sort and hash-agg and hash-join operators.</td>
</tr>
+ <tr>
+ <td><h5>table.exec.state.ttl</h5><br> <span class="label
label-primary">Streaming</span></td>
+ <td style="word-wrap: break-word;">0 ms</td>
+ <td>Duration</td>
+ <td>Specifies a minimum time interval for how long idle state
(i.e. state which was not updated), will be retained. State will never be
cleared until it was idle for less than the minimum time, and will be cleared
at some time after it was idle. Default is never clean-up the state. NOTE:
Cleaning up state requires additional overhead for bookkeeping. Default value
is 0, which means that it will never clean up state.</td>
+ </tr>
Review comment:
@zentol It seems that the documentation generation is not deterministic?
##########
File path: docs/_includes/generated/execution_config_configuration.html
##########
@@ -106,6 +100,12 @@
<td>Boolean</td>
<td>Whether to compress spilled data. Currently we only support
compress spilled data for sort and hash-agg and hash-join operators.</td>
</tr>
+ <tr>
+ <td><h5>table.exec.state.ttl</h5><br> <span class="label
label-primary">Streaming</span></td>
+ <td style="word-wrap: break-word;">0 ms</td>
+ <td>Duration</td>
+ <td>Specifies a minimum time interval for how long idle state
(i.e. state which was not updated), will be retained. State will never be
cleared until it was idle for less than the minimum time, and will be cleared
at some time after it was idle. Default is never clean-up the state. NOTE:
Cleaning up state requires additional overhead for bookkeeping. Default value
is 0, which means that it will never clean up state.</td>
+ </tr>
Review comment:
It would be good to understand where these changes are coming from -- I
want to avoid a situation where the next person generating docs will change the
order again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
