tzulitai opened a new pull request #148: URL: https://github.com/apache/flink-statefun/pull/148
The feedback brokers identify a single pair of producer / consumer with a `SubtaskFeedbackKey`, which is uniquely identified within a job by only the subtask index. This can potentially become an issue in job restart scenarios, since the feedback brokers are static fields, and are durable across non-TM failure job restarts. Currently it is not a problem because we do clear broker channels on close, but adding an extra execution attempt ID into the `SubtaskFeedbackKey` can make things safer. --- ## Verifying this change There are existing unit tests in `FeedbackChannelTest`. Moreover, it is assumed that the failure recover / exactly-once E2E tests have sufficient coverage for this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
