[
https://issues.apache.org/jira/browse/FLINK-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148703#comment-15148703
]
ASF GitHub Bot commented on FLINK-3410:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1643#discussion_r53020089
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -354,9 +358,9 @@ public ExecutionConfig setNumberOfExecutionRetries(int
numberOfExecutionRetries)
*/
@Deprecated
public ExecutionConfig setExecutionRetryDelay(long executionRetryDelay)
{
- if (executionRetryDelay < -1 ) {
+ if (executionRetryDelay < 0 ) {
throw new IllegalArgumentException(
- "The delay between reties must be non-negative,
or -1 (use system default)");
+ "The delay between reties must be
non-negative.");
--- End diff --
we can fix this type while we're at it: reties:retries
> setting setNumberOfExecutionRetries to 0 still leads to RESTARTs.
> -----------------------------------------------------------------
>
> Key: FLINK-3410
> URL: https://issues.apache.org/jira/browse/FLINK-3410
> Project: Flink
> Issue Type: Bug
> Components: JobManager
> Affects Versions: 1.0.0
> Reporter: Robert Metzger
> Assignee: Till Rohrmann
>
> While testing the RC0 for 1.0.0 I found the following issue:
> Setting the number of retries to 0 still leads to the job being restarted:
> {code}
> final StreamExecutionEnvironment see =
> StreamExecutionEnvironment.getExecutionEnvironment();
> see.setNumberOfExecutionRetries(0);
> {code}
> {code}
> 21:19:50,677 INFO org.apache.flink.runtime.jobmanager.JobManager
> - Status of job 0e78d0825da485167aabee7e63c8e913 (Data Generator) changed
> to RESTARTING.
> 21:19:50,678 INFO
> org.apache.flink.runtime.executiongraph.restart.FixedDelayRestartStrategy -
> Delaying retry of job execution for 10000 ms ...
> {code}
> While looking through the code, it seems that the execution config is
> returning {{null}} when the number of retries is set to 0. With {{null}} the
> jobManager picks the default restart strategy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
