Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1633#discussion_r53019468
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -1079,6 +1079,9 @@ class JobManager(
               executionGraph.registerExecutionListener(gateway)
               executionGraph.registerJobStatusListener(gateway)
             }
    +
    +        // All good. Submission succeeded!
    +        jobInfo.client ! 
decorateMessage(JobSubmitSuccess(jobGraph.getJobID))
    --- End diff --
    
    Hmm but now we have the problem that the user might see a 
`JobSubmitSuccess` without the job being stored in the 
`SubmittedJobGraphStore`, right? This means that if the `JobManager` dies 
before the job is persisted, it will never be recovered. I think this violates 
the `JobSubmitSuccess` contract.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to