aljoscha commented on a change in pull request #13358:
URL: https://github.com/apache/flink/pull/13358#discussion_r488636093
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java
##########
@@ -66,7 +66,7 @@
key("rest.address")
.noDefaultValue()
.withFallbackKeys(JobManagerOptions.ADDRESS.key())
- .withDescription("The address that should be used by
clients to connect to the server.");
+ .withDescription("The address that should be used by
clients to connect to the server. Attention: This option is respected only if
the high-availability is NONE.");
Review comment:
```suggestion
.withDescription("The address that should be used by
clients to connect to the server. Attention: This option is respected only if
the high-availability configuration is NONE.");
```
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java
##########
@@ -79,7 +79,7 @@
.withDeprecatedKeys(WebOptions.PORT.key())
.withDescription(
Description.builder()
- .text("The port that the client
connects to. If %s has not been specified, then the REST server will bind to
this port.", text(BIND_PORT.key()))
+ .text("The port that the client
connects to. If %s has not been specified, then the REST server will bind to
this port. Attention: This option is respected only if the high-availability is
NONE.", text(BIND_PORT.key()))
Review comment:
```suggestion
.text("The port that the client
connects to. If %s has not been specified, then the REST server will bind to
this port. Attention: This option is respected only if the high-availability
configuration is NONE.", text(BIND_PORT.key()))
```
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java
##########
@@ -18,16 +18,30 @@
package org.apache.flink.client.cli;
+import org.apache.flink.client.deployment.executors.RemoteExecutor;
import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.DeploymentOptions;
+import org.apache.flink.util.FlinkException;
+import org.apache.flink.util.NetUtils;
import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.Option;
import org.apache.commons.cli.Options;
+import java.net.InetSocketAddress;
+
+import static
org.apache.flink.client.cli.CliFrontend.setJobManagerAddressInConfig;
+
/**
* The default CLI which is used for interaction with standalone clusters.
*/
public class DefaultCLI extends AbstractCustomCommandLine {
+ private static final Option addressOption = new Option("m",
"jobmanager", true,
+ "Address of the JobManager to which to connect. " +
+ "Use this flag to connect to a different JobManager
than the one specified in the configuration. " +
+ "Attention: This option is respected only if the
high-availability is NONE.");
Review comment:
```suggestion
"Attention: This option is respected only if the
high-availability configuration is NONE.");
```
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/AbstractYarnCli.java
##########
@@ -0,0 +1,50 @@
+package org.apache.flink.yarn.cli;
+
+import org.apache.flink.client.cli.AbstractCustomCommandLine;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.DeploymentOptions;
+import org.apache.flink.yarn.configuration.YarnConfigOptions;
+import org.apache.flink.yarn.executors.YarnJobClusterExecutor;
+import org.apache.flink.yarn.executors.YarnSessionClusterExecutor;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+
+abstract class AbstractYarnCli extends AbstractCustomCommandLine {
+
+ private static final String ID = "yarn-cluster";
+
+ protected Option applicationId =
+ new Option("yid", "yarnapplicationId", true, "Attach to running
YARN session");
+
+ protected Option addressOption =
+ new Option("m", "jobmanager", true, "Specify the yarn cluster
mode if the argument equals " + ID);
Review comment:
```suggestion
new Option("m", "jobmanager", true, "Set to " + ID + " to use
YARN execution mode.");
```
This option will be deprecated at some point because we now also have
`--target` and the `GenericCli`. It's good to have it like this for now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
