[
https://issues.apache.org/jira/browse/FLINK-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149274#comment-15149274
]
ASF GitHub Bot commented on FLINK-3401:
---------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1647
[FLINK-3401] [api breaking] AscendingTimestampExtractor only logs violations
This pull requests is based on #1646
The AscendingTimestampExtractor only logs violations of ascending timestamp
order.
Previously it failed hard on a violation. Since that would be in many cases
irrecoverable as soon as one order violation happens in the stream, it it
changed to by default only log violations.
The user can still explicitly set an 'IgnoringHandler' or a
'FailingHandler', which do nothing on violations,
respectively fail hard as before.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink
ascending_extractor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1647
----
commit bfe22cf7ea72941056fbbb657094ec75e58c74c4
Author: Stephan Ewen <se...@apache.org>
Date: 2016-02-16T09:37:59Z
[FLINK-3379] [FLINK-3415] [streaming] Refactor TimestampExtractor into two
separate classes
- one class handled periodic watermarks
- the other class handled watermarks triggered by elements
This also makes sure that any timestamp assigner / watermark generators
cannot generate
negative watermarks
commit 6dcdc3e3a82024c066d73b2d25b27a723bbccdd3
Author: Stephan Ewen <se...@apache.org>
Date: 2016-02-15T17:41:15Z
[FLINK-3401] [streaming] [api breaking] AscendingTimestampExtractor only
logs violations of ascending timestamp order.
The user can also explicitly set an 'IgnoringHandler' or a
'FailingHandler', which do nothing on violations,
respectively fail hard.
----
> AscendingTimestampExtractor should not fail on order violation
> --------------------------------------------------------------
>
> Key: FLINK-3401
> URL: https://issues.apache.org/jira/browse/FLINK-3401
> Project: Flink
> Issue Type: Sub-task
> Components: Streaming
> Affects Versions: 0.10.1
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.0.0
>
>
> Currently, the {{AscendingTimestampExtractor}} fails hard when the order of
> timestamps is violated.
> In the spirit of "streaming jobs never fail", I propose to change the default
> behavior such that violations are only logged (later collected in metrics)
> and that hard failures have to be explicitly activated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
