AHeise commented on a change in pull request #13228:
URL: https://github.com/apache/flink/pull/13228#discussion_r489203616
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java
##########
@@ -159,10 +158,12 @@ public InputStatus emitNext(DataOutput<T> output) throws
Exception {
if (bufferOrEvent.isPresent()) {
// return to the mailbox after receiving a
checkpoint barrier to avoid processing of
// data after the barrier before checkpoint is
performed for unaligned checkpoint mode
- if (bufferOrEvent.get().isEvent() &&
bufferOrEvent.get().getEvent() instanceof CheckpointBarrier) {
+ if (bufferOrEvent.get().isBuffer()) {
+ processBuffer(bufferOrEvent.get());
+ } else {
+ processEvent(bufferOrEvent.get());
Review comment:
Sorry I haven't pulled that change out, since it's more than a
refactoring; it's the core change that modifies the semantics to always return
on events.
Except for that change, everything else is more or less directly related to
passing the priority future, so I'm not sure what to pull out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
