XComp commented on pull request #13316: URL: https://github.com/apache/flink/pull/13316#issuecomment-693440670
> I am not sure about two last hotfixes. > It is true that we tend to use `assertThat`. > On the other hand, the changes arguably do not improve readability a lot > but they change the git history (the lines do not belong to original commit anymore). > This makes harder to analyse the git history. > Therefore I would consider removing the last two commits. Fair enough. I have no strong opinion about it. Maintaining a cleaner git history is a valid reason. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
