walterddr commented on a change in pull request #13356:
URL: https://github.com/apache/flink/pull/13356#discussion_r489506972
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/TaskExecutorRegistration.java
##########
@@ -72,13 +77,15 @@ public TaskExecutorRegistration(
final String taskExecutorAddress,
final ResourceID resourceId,
final int dataPort,
+ final int jmxPort,
final HardwareDescription hardwareDescription,
final TaskExecutorMemoryConfiguration
memoryConfiguration,
final ResourceProfile defaultSlotResourceProfile,
final ResourceProfile totalResourceProfile) {
this.taskExecutorAddress = checkNotNull(taskExecutorAddress);
this.resourceId = checkNotNull(resourceId);
this.dataPort = dataPort;
+ this.jmxPort = jmxPort;
Review comment:
we can do that, in fact it is very similar to the `JobConfigInfo`
message content.
do you want to move `dataPort` and some other components into this generic
metadata collection? (we can mark them deprecated first then remove them in the
next release)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
