SteNicholas commented on a change in pull request #13275:
URL: https://github.com/apache/flink/pull/13275#discussion_r490073844
##########
File path:
flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/source/AbstractTableInputFormat.java
##########
@@ -186,24 +193,22 @@ public void close() throws IOException {
if (resultScanner != null) {
resultScanner.close();
}
- } finally {
- resultScanner = null;
- }
- }
-
- @Override
- public void closeInputFormat() throws IOException {
- try {
if (table != null) {
table.close();
}
+ if (connection != null) {
+ connection.close();
+ }
Review comment:
@rmetzger You are right, but `resultScanner.close()` doesn't throw
exception. Therefore, I just add the close of the connection into catch block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
