dannycranmer commented on a change in pull request #13102:
URL: https://github.com/apache/flink/pull/13102#discussion_r490202899
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java
##########
@@ -277,7 +278,9 @@ public static void
setAwsClientConfigProperties(ClientConfiguration config,
* @return the starting position
*/
public static StartingPosition getStartingPosition(final SequenceNumber
sequenceNumber, final Properties configProps) {
- if
(SENTINEL_AT_TIMESTAMP_SEQUENCE_NUM.get().equals(sequenceNumber)) {
+ if (sequenceNumber.equals(SENTINEL_LATEST_SEQUENCE_NUM.get())) {
+ return StartingPosition.fromTimestamp(new Date());
Review comment:
Done. Also I removed some redundant code as a result of this in
`PollingRecordPublisher`. This means that an additional call to
`GetShardIterator` will be performed when that condition was previously `true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]