[
https://issues.apache.org/jira/browse/FLINK-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150282#comment-15150282
]
ASF GitHub Bot commented on FLINK-3425:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1652#discussion_r53148007
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FileOutputFormat.java
---
@@ -305,6 +305,12 @@ public void tryCleanupOnError() {
this.fileCreated = false;
try {
+ close();
+ } catch (IOException e) {
+ LOG.error("Could not properly close
FileOutputFormat.", e);
--- End diff --
This should probably `fail()` the test
> DataSinkTaskTest.Failing[Sorting]DataSinkTask fails on Windows
> --------------------------------------------------------------
>
> Key: FLINK-3425
> URL: https://issues.apache.org/jira/browse/FLINK-3425
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.0.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.0.0
>
>
> Tests run: 7, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 60.362 sec
> <<< FAILURE! - in org.apache.flink.runtime.operators.DataSinkTaskTest
> testFailingDataSinkTask(org.apache.flink.runtime.operators.DataSinkTaskTest)
> Time elapsed: 4.314 sec <<< FAILURE!
> java.lang.AssertionError: Temp output file has not been removed
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertFalse(Assert.java:64)
> at
> org.apache.flink.runtime.operators.DataSinkTaskTest.testFailingDataSinkTask(DataSinkTaskTest.java:322)
> testFailingSortingDataSinkTask(org.apache.flink.runtime.operators.DataSinkTaskTest)
> Time elapsed: 1.769 sec <<< FAILURE!
> java.lang.AssertionError: Temp output file has not been removed
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertFalse(Assert.java:64)
> at
> org.apache.flink.runtime.operators.DataSinkTaskTest.testFailingSortingDataSinkTask(DataSinkTaskTest.java:362)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
