crazyzhou commented on a change in pull request #13303:
URL: https://github.com/apache/flink/pull/13303#discussion_r491835338
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -149,316 +114,12 @@ public boolean equals(Object o) {
return false;
}
JsonRowDataDeserializationSchema that =
(JsonRowDataDeserializationSchema) o;
- return failOnMissingField == that.failOnMissingField &&
- ignoreParseErrors == that.ignoreParseErrors &&
- resultTypeInfo.equals(that.resultTypeInfo) &&
- timestampFormat.equals(that.timestampFormat);
Review comment:
Keep all the parameters as we had in these (De)SerializationSchema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
