libenchao commented on a change in pull request #13427:
URL: https://github.com/apache/flink/pull/13427#discussion_r491984229
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/WindowAggregateITCase.scala
##########
@@ -347,6 +347,83 @@ class WindowAggregateITCase(mode: StateBackendMode)
assertEquals(expected.sorted, sink.getAppendResults.sorted)
}
+ @Test
+ def testEventTimeTumblingWindowWithOffset(): Unit = {
+ val stream = failingDataSource(data)
+ .assignTimestampsAndWatermarks(
+ new TimestampAndWatermarkWithOffset
+ [(Long, Int, Double, Float, BigDecimal, String, String)](10L))
+ val table = stream.toTable(tEnv,
+ 'rowtime.rowtime, 'int, 'double, 'float, 'bigdec, 'string, 'name)
+ tEnv.registerTable("T1", table)
+
+ val sql =
+ """
+ |SELECT
+ | `string`,
+ | TUMBLE_START(rowtime, INTERVAL '0.005' SECOND, TIME '00:00:00.003'),
Review comment:
@wuchong We can modify the definition of `TUMBLE`/`HOP`/`SESSION` in
`FlinkSqlOperatorTable`, then we have the flexibility to define the operand
types. (Actually I did this in 1.9 internally already)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
