pyscala commented on a change in pull request #13214: URL: https://github.com/apache/flink/pull/13214#discussion_r491815885
########## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestFormatDeserializationOnlyFactory.java ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.factories; + +import org.apache.flink.api.common.serialization.DeserializationSchema; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.table.connector.format.DecodingFormat; +import org.apache.flink.table.data.RowData; + +import java.util.Collections; +import java.util.Set; + +/** + * Tests implementations for {@link DeserializationFormatFactory}. + */ +public class TestFormatDeserializationOnlyFactory implements DeserializationFormatFactory { + + public static final String IDENTIFIER = "test-format-deserialization-only"; + + /** + * Creates a format from the given context and format options. + * + * <p>The format options have been projected to top-level options (e.g. from {@code key.format.ignore-errors} + * to {@code format.ignore-errors}). + * + * @param context + * @param formatOptions + */ Review comment: @wuchong Thanks for your reply. Sounds good to me, I will do it later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
