rmetzger commented on a change in pull request #13424:
URL: https://github.com/apache/flink/pull/13424#discussion_r492636298
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherJob.java
##########
@@ -119,11 +119,17 @@ private DispatcherJob(
}
});
} else { // failure during initialization
- final Throwable strippedThrowable =
ExceptionUtils.stripCompletionException(throwable);
+ JobStatus finalStatus =
JobStatus.FAILED;
+ Throwable strippedThrowable =
ExceptionUtils.stripCompletionException(throwable);
+ if (throwable instanceof
JobInitializationCancelledException) {
Review comment:
but there is no jobManagerRunner available if it's initialization failed
exceptionally.
I will add a unit test that ensures the correct exception types to avoid
accidental changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
