wuchong commented on a change in pull request #13289:
URL: https://github.com/apache/flink/pull/13289#discussion_r492517117



##########
File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkPlannerImpl.scala
##########
@@ -163,7 +163,35 @@ class FlinkPlannerImpl(
         sqlValidator.getCatalogReader.unwrap(classOf[CalciteCatalogReader]),
         cluster,
         convertletTable,
-        sqlToRelConverterConfig)
+        sqlToRelConverterConfig) {
+        // override convertFrom() to support flexible Temporal Table Syntax,
+        // this can be revert once FLINK-16579(Upgrade Calcite version to 
1.23) resolved.
+        val relBuilder = config.getRelBuilderFactory.create(cluster, null)
+
+        override def convertFrom(bb: SqlToRelConverter#Blackboard, from: 
SqlNode): Unit = {

Review comment:
       Create a JIRA issue to remove this overriding once we bump up Calcite 
version. And add comment above this method with the JIRA id. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to